[ 
https://issues.apache.org/jira/browse/PARQUET-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392806#comment-17392806
 ] 

ASF GitHub Bot commented on PARQUET-2070:
-----------------------------------------

sv3ndk commented on pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919#issuecomment-892428149


   Makes sense, thanks for the merge @gszadovszky


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace deprecated syntax in protobuf support
> ---------------------------------------------
>
>                 Key: PARQUET-2070
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2070
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: Svend Vanderveken
>            Assignee: Svend Vanderveken
>            Priority: Minor
>
>  This is trivial change, though at the moment ProtoWriteSupport.java is 
> producing a human-readable JSON output of the protobuf schema with  the 
> following deprecated syntax:
>  
> {code:java}
> TextFormat.printToString(asProto){code}
>  
> Also, the method where is code is present executed one reflection invocation 
> to get the protobuf descriptor which is unnecesserary since the context from 
> where it's called already has this descriptor.
> => all minor and trivial stuff though well, housekeeping I guess :)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to