shangxinli commented on a change in pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805042201
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java
##########
@@ -248,15 +248,18 @@ public DictionaryPage readDictionaryPage() {
private final Map<ColumnDescriptor, ColumnChunkPageReader> readers = new
HashMap<ColumnDescriptor, ColumnChunkPageReader>();
private final long rowCount;
+ private final long rowIndexOffset;
private final RowRanges rowRanges;
- public ColumnChunkPageReadStore(long rowCount) {
+ public ColumnChunkPageReadStore(long rowCount, long rowIndexOffset) {
Review comment:
Since it is defined as public, it could break if we don't maintain the
original signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
