shangxinli commented on a change in pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805044955
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java
##########
@@ -265,6 +268,11 @@ public long getRowCount() {
return rowCount;
}
+ @Override
+ public Optional<Long> getRowIndexOffset() {
+ return Optional.of(rowIndexOffset);
Review comment:
If the constructor caller cannot have a valid rowIndexOffset, I guess
we need to provide an option to return empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
