rdblue commented on code in PR #950:
URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842085396
##########
parquet-column/src/main/java/org/apache/parquet/column/ColumnDescriptor.java:
##########
@@ -70,7 +71,20 @@ public ColumnDescriptor(String[] path, PrimitiveTypeName
type,
* @param maxDef the maximum definition level for that path
*/
public ColumnDescriptor(String[] path, PrimitiveType type, int maxRep, int
maxDef) {
+ this(path, null, type, maxRep, maxDef);
+ }
+
+ /**
+ * @param path the path to the leaf field in the schema
+ * @param id the id to the leaf field in the schema
+ * @param type the type of the field
+ * @param maxRep the maximum repetition level for that path
+ * @param maxDef the maximum definition level for that path
+ * @deprecated will be removed in 2.0.0; Use {@link
#ColumnDescriptor(String[], PrimitiveType, int, int)}
Review Comment:
Is this correct? I would expect to deprecate the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]