rdblue commented on code in PR #950:
URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842086583
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -266,6 +269,10 @@ public int getMaxBloomFilterBytes() {
return maxBloomFilterBytes;
}
+ public boolean getColumnIdResolution() {
Review Comment:
I prefer to use the verb from the setting, rather than adding `get` as a
second verb. Code will read more easily if you use `boolean
resolveColumnsByID()`. You can also add "should" or "is" to denote that the
return is a boolean if you like that convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
