[
https://issues.apache.org/jira/browse/PARQUET-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606210#comment-17606210
]
ASF GitHub Bot commented on PARQUET-2192:
-----------------------------------------
wangyum commented on code in PR #997:
URL: https://github.com/apache/parquet-mr/pull/997#discussion_r973641198
##########
.github/workflows/test.yml:
##########
@@ -43,9 +43,18 @@ jobs:
bash dev/ci-before_install.sh
- name: install
run: |
+ EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate
-Dexpression=extraJavaTestArgs -q -DforceStdout)
+ export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true
-Dsource.skip=true -Djava.version=${{ matrix.java }}
- name: verify
env:
TEST_CODECS: ${{ matrix.codes }}
+ JAVA_VERSION: ${{ matrix.java }}
run: |
- mvn verify --batch-mode javadoc:javadoc -Pci-test
+ EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate
-Dexpression=extraJavaTestArgs -q -DforceStdout)
+ export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
+ if [ "$JAVA_VERSION" = "17" ]; then
+ mvn verify --batch-mode -Pci-test
Review Comment:
Do not test `javadoc` if running on JDK 17:
```
Warning: Creating fake javadoc directory to prevent repeated invocations:
/home/runner/work/parquet-mr/parquet-mr/parquet-jackson/target/site/apidocs
Error: Error fetching link:
/home/runner/work/parquet-mr/parquet-mr/parquet-format-structures/target/site/apidocs/package-list.
Ignored it.
Error: Error fetching link:
/home/runner/work/parquet-mr/parquet-mr/parquet-common/target/site/apidocs/package-list.
Ignored it.
Error: Error fetching link:
/home/runner/work/parquet-mr/parquet-mr/parquet-column/target/site/apidocs/package-list.
Ignored it.
Error: Error fetching link:
/home/runner/work/parquet-mr/parquet-mr/parquet-jackson/target/site/apidocs/package-list.
Ignored it.
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Parquet MR 1.13.0-SNAPSHOT:
[INFO]
[INFO] Apache Parquet MR .................................. SUCCESS [ 3.430
s]
[INFO] Apache Parquet Format Structures ................... SUCCESS [ 7.595
s]
[INFO] Apache Parquet Generator ........................... SUCCESS [ 2.002
s]
[INFO] Apache Parquet Common .............................. SUCCESS [ 6.150
s]
[INFO] Apache Parquet Encodings ........................... SUCCESS [ 13.106
s]
[INFO] Apache Parquet Column .............................. SUCCESS [ 34.259
s]
[INFO] Apache Parquet Arrow ............................... SUCCESS [ 2.889
s]
[INFO] Apache Parquet Jackson ............................. SUCCESS [ 1.578
s]
[INFO] Apache Parquet Hadoop .............................. FAILURE [09:31
min]
[INFO] Apache Parquet Avro ................................ SKIPPED
[INFO] Apache Parquet Benchmarks .......................... SKIPPED
[INFO] Apache Parquet Command-line ........................ SKIPPED
[INFO] Apache Parquet Pig ................................. SKIPPED
[INFO] Apache Parquet Pig Bundle .......................... SKIPPED
[INFO] Apache Parquet Protobuf ............................ SKIPPED
[INFO] Apache Parquet Scala ............................... SKIPPED
[INFO] Apache Parquet Thrift .............................. SKIPPED
[INFO] Apache Parquet Hadoop Bundle ....................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 10:43 min
[INFO] Finished at: 2022-09-16T10:12:42Z
[INFO]
------------------------------------------------------------------------
Error: Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc (default-cli) on
project parquet-hadoop: An error has occurred in Javadoc report generation:
Error: Exit code: 1 -
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/package-info.java:33:
error: unexpected end tag: </p>
Error: * </p>
Error: ^
Error:
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/crypto/AADPrefixVerifier.java:22:
warning: no comment
Error: public interface AADPrefixVerifier {
Error: ^
Error:
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java:29:
warning: no comment
Error: public class AesCipher {
Error: ^
Error:
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java:47:
warning: no comment
Error: protected SecretKeySpec aesKey;
Error: ^
Error:
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java:38:
warning: no comment
Error: protected static final int CHUNK_LENGTH = 4 * 1024;
Error: ^
Error:
/home/runner/work/parquet-mr/parquet-mr/parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java:49:
warning: no comment
Error: protected Cipher cipher;
Error: ^
```
> Add Java 17 build test to GitHub action
> ---------------------------------------
>
> Key: PARQUET-2192
> URL: https://issues.apache.org/jira/browse/PARQUET-2192
> Project: Parquet
> Issue Type: Test
> Components: parquet-testing
> Affects Versions: 1.13.0
> Reporter: Yuming Wang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
