[
https://issues.apache.org/jira/browse/PARQUET-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606451#comment-17606451
]
ASF GitHub Bot commented on PARQUET-2192:
-----------------------------------------
gszadovszky commented on code in PR #997:
URL: https://github.com/apache/parquet-mr/pull/997#discussion_r973912430
##########
.github/workflows/test.yml:
##########
@@ -43,9 +43,18 @@ jobs:
bash dev/ci-before_install.sh
- name: install
run: |
+ EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate
-Dexpression=extraJavaTestArgs -q -DforceStdout)
+ export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true
-Dsource.skip=true -Djava.version=${{ matrix.java }}
- name: verify
env:
TEST_CODECS: ${{ matrix.codes }}
+ JAVA_VERSION: ${{ matrix.java }}
run: |
- mvn verify --batch-mode javadoc:javadoc -Pci-test
+ EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate
-Dexpression=extraJavaTestArgs -q -DforceStdout)
+ export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
+ if [ "$JAVA_VERSION" = "17" ]; then
+ mvn verify --batch-mode -Pci-test
Review Comment:
Are you sure it is easier to skip javadoc instead of fixing the issues? I
only can see one error above which is about an extra `</p>`.
> Add Java 17 build test to GitHub action
> ---------------------------------------
>
> Key: PARQUET-2192
> URL: https://issues.apache.org/jira/browse/PARQUET-2192
> Project: Parquet
> Issue Type: Test
> Components: parquet-testing
> Affects Versions: 1.13.0
> Reporter: Yuming Wang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
