etseidl commented on code in PR #197:
URL: https://github.com/apache/parquet-format/pull/197#discussion_r1303211127
##########
src/main/thrift/parquet.thrift:
##########
@@ -974,6 +1050,13 @@ struct ColumnIndex {
/** A list containing the number of null values for each page **/
5: optional list<i64> null_counts
+ /**
+ * Repetition and definition level histograms for the pages.
+ *
+ * This contains some redundancy with null_counts, however, to accommodate
the
+ * widest range of readers both should be populated.
+ **/
+ 6: optional list<RepetitionDefinitionLevelHistogram>
repetition_definition_level_histograms;
Review Comment:
> I think it's kind of changing `OffsetIndex` to `PageHeader` Group. So
currently I think maybe build it in `OffsetIndex` is not a good idea.
@mapleFU I see your point. I'll pose a question I asked earlier...should I
instead propose a new structure on the dev list to hold this unencoded size
information? A structure similar to the current OffsetIndex, but separate from
it and completely optional? Given how easy it is for files to explode in size
upon full decoding, I think it's useful to be able to know this up front by
only reading from the footer of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
