zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1335131781
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java:
##########
@@ -276,4 +279,24 @@ public String toString() {
return "BINARY_AS_SIGNED_INTEGER_COMPARATOR";
}
};
+
+ /**
+ * This comparator is for comparing two float16 values represented in 2
bytes binary.
+ */
+ static final PrimitiveComparator<Binary> BINARY_AS_FLOAT16_COMPARATOR = new
BinaryComparator() {
Review Comment:
added a test for the comparator!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
