zhangjiashen commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1335132433
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java:
##########
@@ -448,4 +449,16 @@ private void appendHex(byte[] array, int offset, int
length, StringBuilder build
}
}
};
+
+ static final PrimitiveStringifier FLOAT16_STRINGIFIER = new
BinaryStringifierBase("FLOAT16_STRINGIFIER") {
+
+ @Override
+ String stringifyNotNull(Binary value) {
+ if (value.length() != 2) {
+ return BINARY_INVALID;
+ }
+ ByteBuffer buffer = value.toByteBuffer().order(ByteOrder.LITTLE_ENDIAN);
+ return
DEFAULT_STRINGIFIER.stringify(toFloat(buffer.getShort(buffer.position())));
Review Comment:
Added a Float16.toFloatString(..) method and please help check if it makes
sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
