gszadovszky commented on code in PR #1209: URL: https://github.com/apache/parquet-mr/pull/1209#discussion_r1408884415
########## pom.xml: ########## @@ -512,6 +515,43 @@ </configuration> </plugin> + <!-- https://mvnrepository.com/artifact/com.diffplug.spotless/spotless-maven-plugin --> + <plugin> + <groupId>com.diffplug.spotless</groupId> + <artifactId>spotless-maven-plugin</artifactId> + <version>${spotless.version}</version> + <configuration> + <java> + <excludes> + <exclude>**/generated-sources/**</exclude> + </excludes> + <toggleOffOn/> + <removeUnusedImports/> + <importOrder/> + <trimTrailingWhitespace/> + <palantirJavaFormat/> + <endWithNewline/> + <formatAnnotations/> + <indent> + <tabs>true</tabs> + <spacesPerTab>4</spacesPerTab> + </indent> Review Comment: Does it mean we allow tabs for indention? (Personally, I don't like tabs because it might be rendered differently on different systems.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org