amousavigourabi commented on code in PR #1209:
URL: https://github.com/apache/parquet-mr/pull/1209#discussion_r1409748314


##########
pom.xml:
##########
@@ -512,6 +515,43 @@
         </configuration>
       </plugin>
 
+      <!-- 
https://mvnrepository.com/artifact/com.diffplug.spotless/spotless-maven-plugin 
-->
+      <plugin>
+        <groupId>com.diffplug.spotless</groupId>
+        <artifactId>spotless-maven-plugin</artifactId>
+        <version>${spotless.version}</version>
+        <configuration>
+          <java>
+            <excludes>
+              <exclude>**/generated-sources/**</exclude>
+            </excludes>
+            <toggleOffOn/>
+            <removeUnusedImports/>
+            <importOrder/>
+            <trimTrailingWhitespace/>
+            <palantirJavaFormat/>
+            <endWithNewline/>
+            <formatAnnotations/>
+            <indent>
+              <tabs>true</tabs>
+              <spacesPerTab>4</spacesPerTab>
+            </indent>

Review Comment:
   No, tabs are _not_ allowed by this configuration. This block is a way to 
make the linter work as it should with two space indents as used by Parquet, 
instead of four.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to