Thanks for making the release, Fokko. Checked tarball content, checksum and signature. Also was able to execute the build/unit tests from the tarball. Everything passed. +1 (binding)
Cheers, Gabor Fokko Driesprong <fo...@apache.org> ezt írta (időpont: 2024. nov. 29., P, 16:21): > Hey Raúl, > > Thanks for taking the time to vote. > > Regarding the KEYS file, we had a similar discussion at the Iceberg > <https://lists.apache.org/thread/8j41w4y2jx6r3ybj0o82bfyn0npmhgx2> > project. > There we ended up merging the KEYS into the release one, and then point to > the mirror: https://downloads.apache.org/parquet/KEYS. Let me start a > thread to discuss the same approach at Parquet, to keep things nice and > simple. Thanks for noticing this. > > For the part around the licenses. I think we can exclude the .gitignore > from the source distribution, but we have to include the pom.xml. There are > probably more pom's. If you'd be interested in adding a license similar to > the one in Spark <https://github.com/apache/spark/blob/master/pom.xml>, > that would be great! > > Kind regards, > Fokko > > Op vr 29 nov 2024 om 15:56 schreef Raúl Cumplido <rau...@apache.org>: > > > +1 (non-binding) > > > > I've validated signature, checksum and licenses. > > > > I've found a couple of minor things: > > It seems the GPG key is missing from the dev repository [1]. The GPG key > > used to sign is correct on the Release repository [2] so it shouldn't be > an > > issue but would be worth adding it to the dev ones for future reference. > > > > I've found some files without a license that could have one but no code > > related. I can create a PR following this up: > > apache-parquet-1.15.0/.gitignore > > apache-parquet-1.15.0/pom.xml > > > > Thanks Fokko for the release! > > Raúl > > > > [1] https://dist.apache.org/repos/dist/dev/parquet/KEYS > > [2] https://dist.apache.org/repos/dist/release/parquet/KEYS > > > > El vie, 29 nov 2024 a las 15:30, Fokko Driesprong (<fo...@apache.org>) > > escribió: > > > > > +1 from my end as well. > > > > > > The test-suites of both Spark < > > https://github.com/apache/spark/pull/48970> > > > and Iceberg <https://github.com/apache/iceberg/pull/11656> are all > > green! > > > Also checked signature, checksum and licenses. > > > > > > Kind regards, > > > Fokko > > > > > > Op vr 29 nov 2024 om 02:56 schreef Gang Wu <ust...@gmail.com>: > > > > > > > +1 > > > > > > > > Verified the build, checksum and signature locally. Thanks Fokko! > > > > > > > > On Fri, Nov 29, 2024 at 6:27 AM Fokko Driesprong <fo...@apache.org> > > > wrote: > > > > > > > > > Hi everyone, > > > > > > > > > > I propose the following RC to be released as the official Apache > > > Parquet > > > > > 1.15.0 release. > > > > > > > > > > The commit id is 4665401d36e468c988322f78621da7c2d1c22ede > > > > > > > > > > - This corresponds to the tag: apache-parquet-1.15.0-rc2 > > > > > - > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/tree/4665401d36e468c988322f78621da7c2d1c22ede > > > > > > > > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > > > > > - > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.15.0-rc2 > > > > > > > > > > > > > > > You can find the KEYS file here: > > > > > > > > > > - https://downloads.apache.org/parquet/KEYS > > > > > > > > > > > > > > > You can find the changelog here: > > > > > > > > > > - > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.0-rc2 > > > > > > > > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > > > > > - > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheparquet-1067/ > > > > > > > > > > > > > > > After RC1, the following patches have been applied: > > > > > > > > > > - MINOR: Add shading for JDK22-specific classes. > > > > > <https://github.com/apache/parquet-java/pull/3081> > > > > > - MINOR: Revert buildnumber-maven-plugin to 3.2.0 > > > > > <https://github.com/apache/parquet-java/pull/3082> > > > > > - GH-3086: <https://github.com/apache/parquet-java/issues/3086> > > > Allow > > > > > for empty beans < > https://github.com/apache/parquet-java/pull/3087 > > > > > > > > > > > > > Please download, verify, and test. Please vote in the next 72 > hours. > > > > > > > > > > [ ] +1 Release this as Apache Parquet 1.15.0 > > > > > [ ] +0 > > > > > [ ] -1 Do not release this because... > > > > > > > > > > Kind regards, > > > > > Fokko Driesprong > > > > > > > > > > > > > > >
