[ https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925987#comment-13925987 ]
John Hewson commented on PDFBOX-1963: ------------------------------------- Yes, more unit tests! 1) and 2) look good to me. I'm not sure about 3) because Sun's "Binary Code License" is explicitly listed as being [prohibited for Apache projects|https://www.apache.org/legal/resolved.html#prohibited], but it's not clear exactly what is and isn't permitted, so I've opened LEGAL-195 to ask this question. > PDFImageWriter doesn't make use of PDFStreamEngine > -------------------------------------------------- > > Key: PDFBOX-1963 > URL: https://issues.apache.org/jira/browse/PDFBOX-1963 > Project: PDFBox > Issue Type: Improvement > Components: Utilities > Affects Versions: 2.0.0 > Reporter: John Hewson > Assignee: John Hewson > Fix For: 2.0.0 > > > PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of > its functionality, the writeImage methods could be marked as static and > behave in the same manner. > The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no > longer matches its historical origins and needs to be refactored. -- This message was sent by Atlassian JIRA (v6.2#6252)