[ 
https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926201#comment-13926201
 ] 

John Hewson commented on PDFBOX-1963:
-------------------------------------

I've found the problem with PNG resolution, "HorizontalPixelSize" is repeated 
twice:

{code}
Element h = new IIOMetadataNode("HorizontalPixelSize");
h.setAttribute("value", Double.toString(dpi / 25.4));
dimension.appendChild(h);

Element v = new IIOMetadataNode("HorizontalPixelSize");
v.setAttribute("value", Double.toString(dpi / 25.4));
dimension.appendChild(v);
{code}

But it should be "VerticalPixelSize" the second time. Fixed in 1576078..

> PDFImageWriter doesn't make use of PDFStreamEngine
> --------------------------------------------------
>
>                 Key: PDFBOX-1963
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1963
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>            Assignee: John Hewson
>             Fix For: 2.0.0
>
>
> PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of 
> its functionality, the writeImage methods could be marked as static and 
> behave in the same manner.
> The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no 
> longer matches its historical origins and needs to be refactored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to