[ 
https://issues.apache.org/jira/browse/PDFBOX-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696508#comment-14696508
 ] 

Tilman Hausherr commented on PDFBOX-2423:
-----------------------------------------

That's what I suggested 3 days ago and didn't get an answer - you'd need to 
update your patch to the current trunk, then reattach it here, and I'd retest 
it. If it brings more correct files than the current trunk, while not bringing 
any regressions on non-transparency files, then it should be applied.

> Page tree handling needs rewriting
> ----------------------------------
>
>                 Key: PDFBOX-2423
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2423
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.7, 2.0.0
>            Reporter: John Hewson
>            Assignee: John Hewson
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: 025957.pdf, 26101_Colors.ai-1.png, 
> 26101_Colors.ai-1.png-diff.png, Basiswissen-Vorschriften.pdf-3.png, 
> Basiswissen-Vorschriften.pdf-3.png-diff.png, 
> Basiswissen-Vorschriften.pdf-4.png, 
> Basiswissen-Vorschriften.pdf-4.png-diff.png, PDFBOX-1058.pdf-1.png, 
> PDFBOX-1058.pdf-1.png-diff.png, PDFBOX-1058.pdf-4.png, 
> PDFBOX-1058.pdf-4.png-diff.png, PDFBOX-1094-tiling_pattern.pdf, 
> PDFBOX-1711-cmyk.pdf-1.png, PDFBOX-1711-cmyk.pdf-1.png-diff.png, 
> PDFBOX-1794-vattenfall.pdf-1.png, PDFBOX-1794-vattenfall.pdf-1.png-diff.png, 
> PDFBOX-1917.pdf-1.png, PDFBOX-1917.pdf-1.png-diff.png, 
> Transparency_group_rewrite3.patch, asy-functionshading.pdf-1.png, 
> asy-functionshading.pdf-1.png-diff.png, bugzilla869140.pdf, 
> example_026.pdf-1.png, gs-bugilla691763.pdf, gs-bugzilla688601.pdf, 
> gs-bugzilla689518.pdf, gs-bugzilla690467.pdf, gs-bugzilla693322.pdf, 
> gs-bugzilla694385.pdf, jagpdf_doc_patterns.pdf, samsung_galaxy_s_4_um-p1.pdf
>
>
> The way in which PDFBox handles the Page tree needs to be rewritten, 
> preferably from scratch. Currently the document catalog returns the raw 
> objects from the page tree, wrapped in either a PDPage or PDPageNode.
> We need to abstract over the page tree and get rid of PDPageNode, we should 
> provide methods which can add/remove PDPage objects *only*. The existing 
> low-level access to the page tree is not needed at the PD-level.
> Inheritance of page properties such as crop box, resources, and rotation 
> should be reimplemented to use whatever new page tree abstraction we invent. 
> We can finally remove the old broken methods which didn't look up the 
> inheritance tree when retrieving these values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to