[
https://issues.apache.org/jira/browse/PDFBOX-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449650#comment-15449650
]
Tilman Hausherr commented on PDFBOX-3065:
-----------------------------------------
I don't like the name {{initExternalSigning}}, which is really saving the file
incrementally. I'd prefer some other name. What it does is:
- {{saveIncremental}} without closing
- {{return new SigningSupport(writer);}}
- {{writeSignature}} should also get a better name, e.g. {{lateWriteSignature}}
or {{writeExternalSignature}} or whatever
- after {{cosWriter.close();}} you should set cosWriter to null
Re 2.0 - the question is, could somebody who has written signature code like in
the examples still use that code unchanged (I assume yes, per "that original
signing scenario using SignatureInterface via PDDocument does not change at
all")? And even if it is compatible - it would mean that after release in a
2.0.* version, we can't change the API if we don't like it.
Another thought: why not remove the "internal" signing in 2.1 and only keep the
external signing API? Should be discussed with people who have created or
discussed issues about signing. This would simplify the code.
> Right now PDFBOX does not permit to sign multiple files while calling an
> external signing service.
> --------------------------------------------------------------------------------------------------
>
> Key: PDFBOX-3065
> URL: https://issues.apache.org/jira/browse/PDFBOX-3065
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 1.8.10
> Environment: Any Operating systems.
> Reporter: Andrea Paternesi
> Labels: features
> Fix For: 2.1.0
>
> Attachments: PDFBOX-3065_viaExternalSigningSupport_v2.patch,
> PDFBOX-3065_viaExternalSigningSupport_v3.patch
>
>
> Since to sign a PDF you forced the implementation of the SignatureInterface
> interface, is not possible to prepare N hashes from N PDF files and then send
> them to a signing service that accepts multiple hashes with a single signon.
> For example if I use an OTP signing service.
> What would be nice to have is to separate the hash calculation from the
> signing.
> Instead to implement the Interface I would like to have something like this:
> 1) calculate hash from document with the new signature dictionary bytes
> 2) sign the hash
> 3) insert the signature into pdf
> This way I could achieve to sign for example 100 pdf files calling the
> service once.
> Right now must ask the user to sign in 100 times.
> Thanks in advance.
> Andrea.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
