[
https://issues.apache.org/jira/browse/PDFBOX-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467930#comment-15467930
]
Tilman Hausherr commented on PDFBOX-3065:
-----------------------------------------
I have reviewed your code and didn't find any problems, rather some weirdness
in the existing COSWriter code:
- formatDecimal never used
- COSStandardOutputStream with int parameter
- initWriter => rename to e.g. initForIncrementalUpdates
- remove tempIncInput and COSWriter constructor (deprecated anyway)
- signStream is never closed (both in current and in new code)
- COSFilterInputStream has int parameters (harmless in COSWriter, as the
incremental part is small, but not in PDSignature)
Your code:
- Test missing for external signing (but I tried and it works find)
- SigningSupport should better not be public, but probably must because in
different package
You're using COSFilterInputStream in getDataToSign() while the old code just
used a byte buffer. I assume you did this to lessen the memory footprint,
especially because it might be called many times before the actual signing
takes place?
I'll probably commit your code later this week.
> Right now PDFBOX does not permit to sign multiple files while calling an
> external signing service.
> --------------------------------------------------------------------------------------------------
>
> Key: PDFBOX-3065
> URL: https://issues.apache.org/jira/browse/PDFBOX-3065
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 1.8.10
> Environment: Any Operating systems.
> Reporter: Andrea Paternesi
> Labels: features
> Fix For: 2.0.3, 2.1.0
>
> Attachments: PDFBOX-3065_viaExternalSigningSupport_v2.patch,
> PDFBOX-3065_viaExternalSigningSupport_v3.patch,
> PDFBOX-3065_viaExternalSigningSupport_v4.patch
>
>
> Since to sign a PDF you forced the implementation of the SignatureInterface
> interface, is not possible to prepare N hashes from N PDF files and then send
> them to a signing service that accepts multiple hashes with a single signon.
> For example if I use an OTP signing service.
> What would be nice to have is to separate the hash calculation from the
> signing.
> Instead to implement the Interface I would like to have something like this:
> 1) calculate hash from document with the new signature dictionary bytes
> 2) sign the hash
> 3) insert the signature into pdf
> This way I could achieve to sign for example 100 pdf files calling the
> service once.
> Right now must ask the user to sign in 100 times.
> Thanks in advance.
> Andrea.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
