valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493288760
Hi, @lehmi ! I saw your commit "PDFBOX-5178: add LF-combinations to checkForEndOfString..." (https://github.com/apache/pdfbox/commit/86b957ad44b4b23015def8c1319be49450370a3a). As I see, you added more conditions to find the end of string. There seems to be a bug in last 2 conditions (line 428: nextThreeBytes[2] == '/' && nextThreeBytes[2] == '>'). As you see nextThreeBytes[2] cannot have 2 values in the same time. It looks like the OR-operator needed. Additionally, line 424 looks suspect, because you are checking the "nextThreeBytes[0] == ASCII_CR" condition 2 times (427). Did you forget round brackets for 2 conditions in the line 424? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
