valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1523556089
Hi, @THausherr! I found several issues for pdfbox. 1 PDColorspace and PDSpecialColorSpace have the same implementation of getCOSObject method (inheritance) 2 PageDrawer.getDashArray. Line 750: I not found PDFBOX-3360. Line 751: condition Float.isNaN(phase) is always false because phase is integer. Maybe you need something like Float.isNaN(Float.intBitsToFloat(phase)). 3 CMapParser.readDictionary. Second condition of while loop is always true because key is LiteralName and MARK_END_OF_DICTIONARY is String. It looks like you need compare to LiteralName.name field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
