[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

[via GitHub]

valerybokov commented on PR #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493299810

   @lehmi , as I see, 
   
   > @valerybokov thanks for the pointer. I've fixed the buggy condition and 
replaced the and- with an or-operator including some brackets. Checking 
nextThreeBytes[0] two times was intented. I've added another case to the end of 
string detection, see comment. IMHO to split up those 3 cases in two statements 
makes it more readable.
   
   @lehmi , as I see, for both your versions if "nextThreeBytes[0] == ASCII_CR" 
then braces will be set to zero with no other checks.
   
![image](https://user-images.githubusercontent.com/67366451/229348848-94def155-2c90-40d3-8081-4cbc210da75f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org