[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782953#comment-17782953
 ] 

Axel Howind commented on PDFBOX-5660:
-------------------------------------

added patch "replace_System_getProperty()_calls.patch": use the lineSeparator() 
and fileSeparator() methods instead. In theory, a user might call 
System.setProperty() to change the properties at runtime and now get different 
results, but I don't see why that should be done as it is hard to correctly 
determine the consequences of doing so. The JDK methods always return the value 
of both properties that were used at JVM startup.

> Improve code quality (5)
> ------------------------
>
>                 Key: PDFBOX-5660
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5660
>             Project: PDFBox
>          Issue Type: Improvement
>            Reporter: Tilman Hausherr
>            Priority: Minor
>         Attachments: remove_obsolete_class_NullOutputStream.patch, 
> replace_System_getProperty()_calls.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to