[
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794256#comment-17794256
]
Axel Howind commented on PDFBOX-5660:
-------------------------------------
[~tilman] I saw you reverted the javadoc patch that removed the empty caption
tag. Is it mandatory according to some sonarlint rule? The [HTML
spec|https://html.spec.whatwg.org/multipage/tables.html#table-model] says it is
optional:
{quote}In addition to
[cells|https://html.spec.whatwg.org/multipage/tables.html#concept-cell],
[columns|https://html.spec.whatwg.org/multipage/tables.html#concept-column],
[rows|https://html.spec.whatwg.org/multipage/tables.html#concept-row], [row
groups|https://html.spec.whatwg.org/multipage/tables.html#concept-row-group],
and [column
groups|https://html.spec.whatwg.org/multipage/tables.html#concept-column-group],
[tables|https://html.spec.whatwg.org/multipage/tables.html#concept-table] can
have a
{{[caption|https://html.spec.whatwg.org/multipage/tables.html#the-caption-element]}}
element associated with them. This gives the table a heading, or legend.
{quote}
> Improve code quality (5)
> ------------------------
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
> Issue Type: Improvement
> Reporter: Tilman Hausherr
> Priority: Minor
> Attachments:
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
> avoid_multiple_unboxing.patch,
> extract_common_code,_move_toUpperCase()_out_of_loop.patch,
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch,
> make_inner_class_static.patch, remove_obsolete_class_NullOutputStream.patch,
> remove_unnecessary_calls_to_toString()_String_valueOf().patch,
> replace_System_getProperty()_calls.patch, use_Objects_equals().patch,
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
> use_String_join().patch,
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> SonarQube report, hints in different IDEs, the FindBugs tool and other code
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
