[
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794685#comment-17794685
]
Axel Howind commented on PDFBOX-5660:
-------------------------------------
- Added patch "use_Map_ofEntries().patch"
We can directly create the Map without using static initializer and creating
a temporary array.
- Added patch "DRY_refactoring_Typ2CharStringParser.patch"
The two methods differed only in name.
- Added patch
"simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch"
The code is simpler two read if we use the helper methods provided by the
JDK. Also, test name first because it's just a string comparison (hashCode),
and testing the map for equality can be a very expensive operation (because in
the worst case all entries have to be compared) and that is only necessary if
the names match.
> Improve code quality (5)
> ------------------------
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
> Issue Type: Improvement
> Reporter: Tilman Hausherr
> Priority: Minor
> Attachments: DRY_refactoring_Typ2CharStringParser.patch,
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
> avoid_multiple_unboxing.patch,
> extract_common_code,_move_toUpperCase()_out_of_loop.patch,
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch,
> make_inner_class_static.patch, remove_obsolete_class_NullOutputStream.patch,
> remove_unnecessary_calls_to_toString()_String_valueOf().patch,
> replace_System_getProperty()_calls.patch,
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
> use_Map_ofEntries().patch, use_Objects_equals().patch,
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
> use_String_join().patch,
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> SonarQube report, hints in different IDEs, the FindBugs tool and other code
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
