foreverneverer commented on code in PR #1035:
URL: https://github.com/apache/incubator-pegasus/pull/1035#discussion_r916448515
##########
rdsn/src/common/replication_common.h:
##########
@@ -117,6 +117,11 @@ class replication_options
~replication_options();
void initialize();
+
+ int32_t min_2pc_replica_count(int32_t app_max_replica_count)
+ {
+ return std::min(mutation_2pc_min_replica_count, app_max_replica_count)
- 1;
Review Comment:
Oh, the function should be removed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
