foreverneverer commented on code in PR #1035:
URL: https://github.com/apache/incubator-pegasus/pull/1035#discussion_r916453300
##########
rdsn/src/replica/replica.cpp:
##########
@@ -581,5 +581,10 @@ error_code replica::store_app_info(app_info &info, const
std::string &path)
return err;
}
+int32_t replica::mutation_2pc_min_replica_count()
+{
+ return std::min(_options->mutation_2pc_min_replica_count,
_app_info.max_replica_count - 1);
Review Comment:
I retain _options->mutation_2pc_min_replica_count means that in the case:
mutation_2pc_min_replica_count = 2, max_replica_count = 5, but the mim_2pc
should equal with 2 but not 4, if you add `1` , the
mutation_2pc_min_replica_count is invalid and it always equal with 1
But your case is right, so the function should:
```c++
assert(app_info.max_replica_count > 0);
return app_info.max_replica_count <=2 ? 1 :
std::min(_options->mutation_2pc_min_replica_count, _app_info.max_replica_count
- 1);
```
Do you think it is ok？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
