empiredan commented on code in PR #1035:
URL: https://github.com/apache/incubator-pegasus/pull/1035#discussion_r916503997
##########
rdsn/src/replica/replica.cpp:
##########
@@ -581,5 +581,10 @@ error_code replica::store_app_info(app_info &info, const
std::string &path)
return err;
}
+int32_t replica::mutation_2pc_min_replica_count()
+{
+ return std::min(_options->mutation_2pc_min_replica_count,
_app_info.max_replica_count - 1);
Review Comment:
Yeah, this made sense. However, another case is that the replica count is
increased from 1 to 3: since `_options->mutation_2pc_min_replica_count` is
originally set to 1, `std::min(_options->mutation_2pc_min_replica_count,
_app_info.max_replica_count - 1)` will still return 1. Does this means we have
to modify `_options->mutation_2pc_min_replica_count` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
