empiredan commented on code in PR #1035:
URL: https://github.com/apache/incubator-pegasus/pull/1035#discussion_r917500004
##########
rdsn/src/replica/replica.cpp:
##########
@@ -581,5 +581,10 @@ error_code replica::store_app_info(app_info &info, const
std::string &path)
return err;
}
+int32_t replica::mutation_2pc_min_replica_count()
+{
+ return std::min(_options->mutation_2pc_min_replica_count,
_app_info.max_replica_count - 1);
Review Comment:
I think both methods can work well with most cases. Maybe it's better to
reserve `mutation_2pc_min_replica_count` for special cases, so we can adopt
first method ? And while `mutation_2pc_min_replica_count` is not enabled, use
N/2+1 instead (no special reason, since PacificA doesn't need quorum write) ?
```
assert(_app_info.max_replica_count > 0);
if (mutation_2pc_min_replica_count > 0) {// >0 means use the user config
return mutation_2pc_min_replica_count;
} else {// otherwise use the table max_replica_count
return app_info.max_replica_count <=2 ? 1 : _app_info.max_replica_count
/ 2 + 1;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
