acelyc111 commented on code in PR #1045: URL: https://github.com/apache/incubator-pegasus/pull/1045#discussion_r918493761
########## java-client/idl/recompile_thrift.sh: ########## @@ -19,21 +19,28 @@ # under the License. # -# method to get thrift 0.11.0: -# wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz -# tar xvf thrift-0.11.0.tar.gz -# cd thrift-0.11.0 -# ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ -# --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no -# make -# sudo make install -# -# Note: by default the thrift will be installed in /usr/local. If you'd like to install it somewhere else, -# you'd better provide install path with option `--prefix=xxx'. - +function GenThriftTool() { + wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz + tar xvf thrift-0.11.0.tar.gz + cd thrift-0.11.0 + ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ + --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no + make Review Comment: Better to add ` -j $(($(nproc)/2+1))` to make faster. ########## java-client/idl/recompile_thrift.sh: ########## @@ -19,21 +19,28 @@ # under the License. # -# method to get thrift 0.11.0: -# wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz -# tar xvf thrift-0.11.0.tar.gz -# cd thrift-0.11.0 -# ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ -# --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no -# make -# sudo make install -# -# Note: by default the thrift will be installed in /usr/local. If you'd like to install it somewhere else, -# you'd better provide install path with option `--prefix=xxx'. - +function GenThriftTool() { + wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz + tar xvf thrift-0.11.0.tar.gz + cd thrift-0.11.0 + ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ + --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no + make + sudo make install Review Comment: It's suggest to install packages in Dockerfile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
