shenxingwuying commented on code in PR #1045: URL: https://github.com/apache/incubator-pegasus/pull/1045#discussion_r926326756
########## docker/pegasus-build-env/centos6/Dockerfile: ########## @@ -20,16 +20,16 @@ FROM centos:6.10 LABEL maintainer=jiashuo # defaut repo url hasn't been supported, use thirdparty repo url -RUN curl https://www.getpagespeed.com/files/centos6-eol.repo --output /etc/yum.repos.d/CentOS-Base.repo -RUN curl https://www.getpagespeed.com/files/centos6-epel-eol.repo --output /etc/yum.repos.d/epel.repo -RUN curl https://www.getpagespeed.com/files/centos6-scl-eol.repo --output /etc/yum.repos.d/CentOS-SCLo-scl.repo -RUN curl https://www.getpagespeed.com/files/centos6-scl-rh-eol.repo --output /etc/yum.repos.d/CentOS-SCLo-scl-rh.repo +RUN wget --progress=dot:giga https://www.getpagespeed.com/files/centos6-eol.repo -O /etc/yum.repos.d/CentOS-Base.repo Review Comment: 1. Docker lint will warn both curl and wget used together. So avoid this should use only one. 2. curl get the file thrift-0.11.0.tgz, I failed. So I fix curl before to wget. 3. If wget is not exist. Keey curl and ignore the warnings in docker lint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
