acelyc111 commented on code in PR #1045: URL: https://github.com/apache/incubator-pegasus/pull/1045#discussion_r922955476
########## java-client/build.sh: ########## @@ -0,0 +1,31 @@ +#!/bin/bash Review Comment: Add license header ########## java-client/idl/recompile_thrift.sh: ########## @@ -19,21 +19,33 @@ # under the License. # -# method to get thrift 0.11.0: -# wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz -# tar xvf thrift-0.11.0.tar.gz -# cd thrift-0.11.0 -# ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ -# --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no -# make -# sudo make install -# -# Note: by default the thrift will be installed in /usr/local. If you'd like to install it somewhere else, -# you'd better provide install path with option `--prefix=xxx'. - +function GenThriftTool() { + set -e + wget --progress=dot:giga https://github.com/apache/thrift/archive/refs/tags/0.11.0.tar.gz -O thrift-0.11.0.tar.gz + tar xzf thrift-0.11.0.tar.gz + pushd thrift-0.11.0 + ./bootstrap.sh + ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ + --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no Review Comment: We only need the execute binary? You can set `--enable_libs=no` instead. ########## java-client/idl/recompile_thrift.sh: ########## @@ -19,21 +19,33 @@ # under the License. # -# method to get thrift 0.11.0: -# wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz -# tar xvf thrift-0.11.0.tar.gz -# cd thrift-0.11.0 -# ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \ -# --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no -# make -# sudo make install -# -# Note: by default the thrift will be installed in /usr/local. If you'd like to install it somewhere else, -# you'd better provide install path with option `--prefix=xxx'. - +function GenThriftTool() { + set -e + wget --progress=dot:giga https://github.com/apache/thrift/archive/refs/tags/0.11.0.tar.gz -O thrift-0.11.0.tar.gz Review Comment: Why we use thrift-0.11.0 in Java and 0.9.3 in all the other places, there must be some historical reason. I can remember a little there is a compatiable reason in Java client that we shaded thrift 0.11.0, but not sure. Any body could please clarify it? Many thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
