WHBANG commented on code in PR #1108:
URL: https://github.com/apache/incubator-pegasus/pull/1108#discussion_r944228802
##########
src/server/pegasus_server_impl.cpp:
##########
@@ -1560,9 +1560,10 @@ dsn::error_code pegasus_server_impl::start(int argc,
char **argv)
ddebug_replica("start to open rocksDB's rdb({})", rdb_path);
- // Here we create a `tmp_data_cf_opts` because we don't want to modify
`_data_cf_opts`, which
+ // Here we create a `_tmp_data_cf_opts` because we don't want to modify
`_data_cf_opts`, which
// will be used elsewhere.
- rocksdb::ColumnFamilyOptions tmp_data_cf_opts = _data_cf_opts;
+ _tmp_data_cf_opts = _data_cf_opts;
Review Comment:
`_data_cf_opts` involves too many files, not necessary.
i will rename `_tmp_data_cf_opts ` to `_table_data_cf_opts `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
