[GitHub] [incubator-pegasus] WHBANG commented on a diff in pull request #1108: fix: rocksdb options not changed even if update in Pegasus config file

[GitBox]

WHBANG commented on code in PR #1108:
URL: https://github.com/apache/incubator-pegasus/pull/1108#discussion_r945116285


##########
src/server/pegasus_server_impl.cpp:
##########
@@ -3007,6 +3013,97 @@ void pegasus_server_impl::reset_usage_scenario_options(
     target_opts->max_write_buffer_number = base_opts.max_write_buffer_number;
 }
 
+void pegasus_server_impl::recalculate_data_cf_options(
+    const rocksdb::ColumnFamilyOptions &cur_data_cf_opts)
+{
+#define UPDATE_OPTION_IF_NEEDED(option, value, str_value)                      
                    \
+    if ((value) != cur_data_cf_opts.option) {                                  
                    \
+        new_options[#option] = (str_value);                                    
                    \
+    }

Review Comment:
   when `new_options[#option] = #new_value;`run  the following statement:
   ```
   
UPDATE_OPTION_IF_NEEDED(level0_slowdown_writes_trigger,_data_cf_opts.level0_slowdown_writes_trigger)
   ```
   result is bad:
   ```
   new_options["level0_slowdown_writes_trigger"] = 
"_data_cf_opts.level0_slowdown_writes_trigger"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org