acelyc111 commented on code in PR #1108:
URL: https://github.com/apache/incubator-pegasus/pull/1108#discussion_r947425771
##########
src/server/pegasus_server_impl.h:
##########
@@ -414,10 +426,14 @@ class pegasus_server_impl : public pegasus_read_service
std::shared_ptr<rocksdb::Statistics> _statistics;
rocksdb::DBOptions _db_opts;
rocksdb::ColumnFamilyOptions _data_cf_opts;
+ rocksdb::ColumnFamilyOptions _table_data_cf_opts;
Review Comment:
Add some comments to explaint the differece between `_data_cf_opts` and
`_table_data_cf_opts`
##########
src/server/pegasus_server_impl.h:
##########
@@ -414,10 +426,14 @@ class pegasus_server_impl : public pegasus_read_service
std::shared_ptr<rocksdb::Statistics> _statistics;
rocksdb::DBOptions _db_opts;
rocksdb::ColumnFamilyOptions _data_cf_opts;
+ rocksdb::ColumnFamilyOptions _table_data_cf_opts;
rocksdb::ColumnFamilyOptions _meta_cf_opts;
rocksdb::ReadOptions _data_cf_rd_opts;
std::string _usage_scenario;
std::string _user_specified_compaction;
+ // Whether it is necessary to update the current data_cf, it is required
when opening the db,
+ // but not later
+ bool _is_need_update_data_cf_opts;
Review Comment:
How aboout rename ot to `_table_data_cf_opts_recalculated` ? it would be
closer with what you want to do.
##########
src/server/pegasus_server_impl.cpp:
##########
@@ -2634,6 +2635,10 @@ void pegasus_server_impl::update_usage_scenario(const
std::map<std::string, std:
old_usage_scenario,
new_usage_scenario);
}
+ } else {
+ // When an old db is opened and the conf is changed, the options
related to usage scenario
Review Comment:
How about change 'the conf is changed' to 'the rocksDB related configs in
server config.ini has been changed' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
