Apache9 commented on code in PR #1284:
URL:
https://github.com/apache/incubator-pegasus/pull/1284#discussion_r1039117512
##########
go-client/generator/admin.csv:
##########
@@ -1,20 +1,20 @@
-RPC_CM_DROP_APP,DropApp,DropAppRequest,DropAppResponse
-RPC_CM_CREATE_APP,CreateApp,CreateAppRequest,CreateAppResponse
-RPC_CM_RECALL_APP,RecallApp,RecallAppRequest,RecallAppResponse
-RPC_CM_LIST_APPS,ListApps,ListAppsRequest,ListAppsResponse
+RPC_CM_DROP_APP,DropApp,ConfigurationDropAppRequest,ConfigurationDropAppResponse
Review Comment:
No compatiblity issue?
##########
.github/workflows/lint_and_test_go-client.yml:
##########
@@ -36,27 +36,12 @@ on:
# workflow tasks
jobs:
- lint:
- name: Lint
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@v2
- with:
- fetch-depth: 1
- - name: Set up Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.14
- - name: golangci-lint
- uses: golangci/golangci-lint-action@v3
- with:
- version: v1.29
- working-directory: ./go-client
-
build:
- name: Test
- runs-on: ubuntu-latest
+ name: Test and Lint
+ runs-on: ubuntu:20.04
steps:
+ - name: Install thrift
+ run: sudo apt-get install -y thrift-compiler
Review Comment:
We do not need to specify the version of the thrift compiler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
