acelyc111 commented on code in PR #1284: URL: https://github.com/apache/incubator-pegasus/pull/1284#discussion_r1039457292
########## go-client/generator/admin.csv: ########## @@ -1,20 +1,20 @@ -RPC_CM_DROP_APP,DropApp,DropAppRequest,DropAppResponse -RPC_CM_CREATE_APP,CreateApp,CreateAppRequest,CreateAppResponse -RPC_CM_RECALL_APP,RecallApp,RecallAppRequest,RecallAppResponse -RPC_CM_LIST_APPS,ListApps,ListAppsRequest,ListAppsResponse +RPC_CM_DROP_APP,DropApp,ConfigurationDropAppRequest,ConfigurationDropAppResponse Review Comment: There are some compatiblity issues, because the structure names changed. go-client defined it's own idl before, they have the same structure content (the fields type and sequence number) but different names, the go-client side names are more simple and clean, but consider the consistency and maintainability, I think use the unify idl and break some compatiblity would be better, the go-client is not wildly used currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
