acelyc111 commented on code in PR #1284:
URL:
https://github.com/apache/incubator-pegasus/pull/1284#discussion_r1039857851
##########
.github/workflows/lint_and_test_go-client.yml:
##########
@@ -36,27 +36,12 @@ on:
# workflow tasks
jobs:
- lint:
- name: Lint
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@v2
- with:
- fetch-depth: 1
- - name: Set up Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.14
- - name: golangci-lint
- uses: golangci/golangci-lint-action@v3
- with:
- version: v1.29
- working-directory: ./go-client
-
build:
- name: Test
- runs-on: ubuntu-latest
+ name: Test and Lint
+ runs-on: ubuntu:20.04
steps:
+ - name: Install thrift
+ run: sudo apt-get install -y thrift-compiler
Review Comment:
It seems thrift 0.13.0 has been removed from apt for the ubuntu-latest
(22.04), I can't even search it.
Java client depends thrift 0.11.0 in pom, and both cpp and java use thrift
0.11.0 to generate code, but cpp link thrift 0.9.3 💊
We can improve and unify the version in next patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
