GehaFearless commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1418264398
##########
src/client/replication_ddl_client.cpp:
##########
@@ -81,18 +82,51 @@ namespace replication {
using tp_output_format = ::dsn::utils::table_printer::output_format;
-replication_ddl_client::replication_ddl_client(const
std::vector<dsn::rpc_address> &meta_servers)
+replication_ddl_client::replication_ddl_client(const
std::vector<dsn::host_port> &meta_servers)
+ : _dns_resolver(new dns_resolver())
{
_meta_server.assign_group("meta-servers");
for (const auto &m : meta_servers) {
- if (!_meta_server.group_address()->add(m)) {
+ if (!_meta_server.group_host_port()->add(m)) {
LOG_WARNING("duplicate adress {}", m);
}
}
}
replication_ddl_client::~replication_ddl_client() {
_tracker.cancel_outstanding_tasks(); }
+void replication_ddl_client::set_meta_servers_leader()
Review Comment:
`dsn_rpc_call(dns_resolver->resolve_address(hp), rpc_call);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
