GehaFearless commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1421980046
##########
src/common/json_helper.h:
##########
@@ -423,6 +423,21 @@ inline bool json_decode(const dsn::json::JsonObject &in,
dsn::rpc_address &addre
return address.from_string_ipv4(rpc_address_string.c_str());
}
+// json serialization for rpc address, we use the string representation of a
address
+inline void json_encode(JsonWriter &out, const dsn::host_port &hp)
+{
+ json_encode(out, hp.to_string());
+}
+inline bool json_decode(const dsn::json::JsonObject &in, dsn::host_port &hp)
Review Comment:
`TEST(host_port_test, thrift_parser)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
