empiredan commented on code in PR #1597:
URL: 
https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538767939


##########
src/replica/duplication/load_from_private_log.cpp:
##########
@@ -146,6 +146,8 @@ void load_from_private_log::run()
 
 void load_from_private_log::find_log_file_to_start()
 {
+    _duplicator->set_duplication_plog_checking(true);

Review Comment:
   Would it be fine to return from the middle of the function without roll back 
by `_duplicator->set_duplication_plog_checking(false);` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to