empiredan commented on code in PR #1597:
URL:
https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1539095227
##########
src/replica/duplication/load_from_private_log.cpp:
##########
@@ -168,6 +171,8 @@ void load_from_private_log::find_log_file_to_start()
void load_from_private_log::find_log_file_to_start(
const mutation_log::log_file_map_by_index &log_file_map)
{
+ auto cleanup = dsn::defer([this]() {
_duplicator->set_duplication_plog_checking(false); });
Review Comment:
Is this line necessary ?
`_duplicator->set_duplication_plog_checking(false);` would be called twice ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
