empiredan commented on code in PR #1597:
URL:
https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538927914
##########
src/replica/duplication/load_from_private_log.cpp:
##########
@@ -157,6 +159,7 @@ void load_from_private_log::find_log_file_to_start()
error_s es = log_utils::open_read(pr.second->path(), file);
if (!es.is_ok()) {
LOG_ERROR_PREFIX("{}", es);
+ _duplicator->set_duplication_plog_checking(false);
Review Comment:
There's `return` statement in function
`find_log_file_to_start(log_file_map)`, which should be also set false:
```c++
void load_from_private_log::find_log_file_to_start(
const mutation_log::log_file_map_by_index &log_file_map)
{
_current = nullptr;
if (dsn_unlikely(log_file_map.empty())) {
LOG_ERROR_PREFIX("unable to start duplication since no log file is
available");
return;
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
