Apache9 commented on PR #1970: URL: https://github.com/apache/incubator-pegasus/pull/1970#issuecomment-2044600807
> Handle Exception is a good choice. Exception will make the schedule job not schedule again > > But i am not quite understand the main cause about `daemon` I don't kown the relatetionship between daemon thread with exception handler @Samunroyu > > if you set daemon false, you should shutdown the threadpool when client jvm shutdown. I‘ve talked with @Samunroyu offline, the root cause here is we do not have a close method for `KerberosProtocol` class, so if we create the client many time due to kerberos authentication error, although we have already closed all the created client, the `KerberosProtocol` will not be closed, so the ExecutorService will be leaked and cause too many threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
