Samunroyu commented on code in PR #1970:
URL:
https://github.com/apache/incubator-pegasus/pull/1970#discussion_r1568137721
##########
java-client/src/main/java/org/apache/pegasus/security/KerberosProtocol.java:
##########
@@ -50,19 +52,21 @@ class KerberosProtocol implements AuthProtocol {
// request. The JAAS framework defines the term "subject" to represent the
source of a request. A
// subject may be any entity, such as a person or a service.
private Subject subject;
- private String serviceName;
- private String serviceFqdn;
- private String keyTab;
- private String principal;
+ private final String serviceName;
+ private final String serviceFqdn;
+ private final String keyTab;
+ private final String principal;
final int CHECK_TGT_INTEVAL_SECONDS = 10;
final ScheduledExecutorService service =
Executors.newSingleThreadScheduledExecutor(
new ThreadFactory() {
@Override
public Thread newThread(Runnable r) {
- Thread t = new Thread(r);
+ String timestamp = new SimpleDateFormat("HHmmss").format(new
Date());
Review Comment:
> from JDK8 , advise migration to the
[java.time](http://docs.oracle.com/javase/8/docs/api/java/time/package-summary.html)
classes. String timestamp =
LocalTime.now().format(DateTimeFormatter.ofPattern("HHmmss"));
ok, i have changed to use java.time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
