Apache9 commented on code in PR #1970:
URL:
https://github.com/apache/incubator-pegasus/pull/1970#discussion_r1562290509
##########
java-client/src/main/java/org/apache/pegasus/rpc/interceptor/ReplicaSessionInterceptorManager.java:
##########
@@ -49,4 +49,10 @@ public boolean onSendMessage(ReplicaSession session, final
ReplicaSession.Reques
}
return true;
}
+
+ public void close() {
Review Comment:
Ditto.
##########
java-client/src/main/java/org/apache/pegasus/rpc/interceptor/ReplicaSessionInterceptor.java:
##########
@@ -27,4 +27,6 @@ public interface ReplicaSessionInterceptor {
// The behavior when rpc session is sending a message.
// @returns false if this message shouldn't be sent.
boolean onSendMessage(ReplicaSession session, final
ReplicaSession.RequestEntry entry);
+
+ void close();
Review Comment:
Better make this interface extends Closeable
##########
java-client/src/main/java/org/apache/pegasus/security/AuthProtocol.java:
##########
@@ -27,4 +27,6 @@ public interface AuthProtocol {
void authenticate(ReplicaSession session);
boolean isAuthRequest(final ReplicaSession.RequestEntry entry);
+
+ void close();
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
