acelyc111 commented on code in PR #2251: URL: https://github.com/apache/incubator-pegasus/pull/2251#discussion_r2099611601
########## src/server/pegasus_server_impl_init.cpp: ########## @@ -693,6 +745,15 @@ pegasus_server_impl::pegasus_server_impl(dsn::replication::replica *r) _data_cf_opts.max_bytes_for_level_base = FLAGS_rocksdb_max_bytes_for_level_base; _data_cf_opts.max_bytes_for_level_multiplier = FLAGS_rocksdb_max_bytes_for_level_multiplier; + // open db with key-value separation option (rocksdb blobdb) + _data_cf_opts.enable_blob_files = FLAGS_rocksdb_enable_blob_files; Review Comment: What happen if enable this switch on an already running rocksdb instance? Will the data to be lost? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For additional commands, e-mail: dev-h...@pegasus.apache.org