ninsmiracle commented on code in PR #2251:
URL:
https://github.com/apache/incubator-pegasus/pull/2251#discussion_r2099635704
##########
src/server/pegasus_server_impl_init.cpp:
##########
@@ -693,6 +745,15 @@
pegasus_server_impl::pegasus_server_impl(dsn::replication::replica *r)
_data_cf_opts.max_bytes_for_level_base =
FLAGS_rocksdb_max_bytes_for_level_base;
_data_cf_opts.max_bytes_for_level_multiplier =
FLAGS_rocksdb_max_bytes_for_level_multiplier;
+ // open db with key-value separation option (rocksdb blobdb)
+ _data_cf_opts.enable_blob_files = FLAGS_rocksdb_enable_blob_files;
Review Comment:
`enable_blob_files` will affects flush/compaction task after your change,
and will not interrupting ongoing background tasks.
If your turn it from 'true' to 'false', and at the same time
`enable_blob_garbage_collection=true`.:
The background Blob GC thread will continue to scan old files. When the
garbage rate of the entire file exceeds the threshold
(`blob_garbage_collection_force_threshold`), the surviving entries in the file
will be moved to the new SST (not the new blob), and then the original file
will be deleted.
On the other hand, if `enable_blob_garbage_collection=false`, or the keys of
this blob file remain unchanged for a long time, the blob file will stay in
rocksdb for a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
