acelyc111 commented on code in PR #2251: URL: https://github.com/apache/incubator-pegasus/pull/2251#discussion_r2112239193
########## src/server/pegasus_server_impl_init.cpp: ########## @@ -588,6 +588,43 @@ DSN_DEFINE_uint64(pegasus.server, 600, // 600 is the default value in RocksDB. "If not zero, dump rocksdb.stats to RocksDB every stats_persist_period_sec"); +/* Rocksdb blobdb for Key-value separation. + * For more infomation, see: https://github.com/facebook/rocksdb/wiki/BlobDB */ +DSN_DEFINE_bool(pegasus.server, + rocksdb_enable_blob_files, + false, + "switch of the key-value separation function"); Review Comment: Use the description in rocksdb, i.e. "When set, large values (blobs) are written to separate blob files, and only pointers to them are stored in SST files. This can reduce write amplification for large-value use cases at the cost of introducing a level of indirection for reads." It could provide more information, avoid missunderstanding or ambiguity. Other options are the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For additional commands, e-mail: dev-h...@pegasus.apache.org