So upon further inspection there is definitely a difference but it appears to be on file attributes for files (such as NOTICE) that are added to the jars. This can be confirmed by using jardiff which doesn't report any difference since the actual bytecode (which is what's critical) is the same.
I will look into what's causing this, it appears to be either a misconfiguration of sbt-reproducible-builds and/or feature it lacks. Retracting my previous -1 vote and giving +1 On Tue, Aug 8, 2023 at 1:27 PM PJ Fanning <fannin...@apache.org> wrote: > Is there anyone else with time to try out the sbt-reproducible build > checks described at the link below? > > > https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > > > On Tue, 8 Aug 2023 at 11:13, Matthew de Detrich > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > So.I just did a fresh checkout of > > https://github.com/apache/incubator-pekko-management on > > my x86_64 Linux box, set Java to version 1.8 and ran sbt ++2.13 > > reproducibleBuildsCheck > > and it's still reporting the same problem. Furthermore the checksum's on > my > > linux box > > perfectly match the ones on my Macbook M1 with both being different to > what > > is in ASF > > staging repo. > > > > I will look into it more. > > > > On Tue, Aug 8, 2023 at 10:58 AM PJ Fanning <fannin...@gmail.com> wrote: > > > > > Yes, I am using git commit c1bab5a116b7f4c654f9d7ae3886a344e0f3771e. > > > > > > On Tue, 8 Aug 2023 at 09:49, Matthew de Detrich > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > > > Are you sure that you have the code at the 1.0.0-RC2 tag point > > > > > > > > Yes, its tag c1bab5a116b7f4c654f9d7ae3886a344e0f3771e as stated > before. > > > Are > > > > you also checked out at this git tag > > > > > > > > > and that you are running a clean build? > > > > > > > > Yes and I did this twice with JDK 8. I will check this out again a > bit > > > > later today when I have time > > > > > > > > On Tue, Aug 8, 2023 at 10:43 AM PJ Fanning <fannin...@apache.org> > wrote: > > > > > > > > > I get clean matched results when I run the sbt-reproducible-builds > > > > > commands: > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > > > > > > > > > > Are you sure that you have the code at the 1.0.0-RC2 tag point and > > > > > that you are running a clean build? > > > > > > > > > > On Tue, 8 Aug 2023 at 09:00, Matthew de Detrich > > > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > > > > > > So jardiff isn't reporting any differences but diffoscope does, > see > > > > > > > https://gist.github.com/mdedetrich/172c369af2a4ac39e2b21f3ad8e8daf6 > > > . > > > > > The > > > > > > diff appears to be coming from files such as NOTICE and LICENSE, > so I > > > > > think > > > > > > that the issue is that maybe you published from the latest main > > > rather > > > > > than > > > > > > the tag when there was a difference in these files? Here is also > the > > > > > > relevant output of sbt-reproducible-diff for Scala 2.13 > > > > > > > https://gist.github.com/mdedetrich/08e02b787d4f712d104fba1d47252864 > > > > > > > > > > > > Locally I am checking from git tag > > > > > c1bab5a116b7f4c654f9d7ae3886a344e0f3771e > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 8, 2023 at 9:43 AM Matthew de Detrich < > > > > > > matthew.dedetr...@aiven.io> wrote: > > > > > > > > > > > > > I am getting a mismatch in jvm binary jars with > > > > > sbt-reproducible-builds so > > > > > > > I will block the release until I confirm its either an issue > on my > > > end > > > > > or > > > > > > > the binaries are fixed > > > > > > > > > > > > > > -1 > > > > > > > > > > > > > > On Sat, Aug 5, 2023 at 10:23 PM PJ Fanning < > fannin...@apache.org> > > > > > wrote: > > > > > > > > > > > > > >> Hello Pekko Community, > > > > > > >> > > > > > > >> This is a call for a vote to release Apache Pekko(incubating) > > > > > > >> Management version 1.0.0-RC2. > > > > > > >> > > > > > > >> There are some license fixes since 1.0.0-RC1. > > > > > > >> > > > > > > >> The discussion thread: > > > > > > >> > > > > > > >> > https://lists.apache.org/thread/g1hhcsvzbd8o1zdholds41k0jrknrx3q > > > > > > >> > > > > > > >> The release candidate: > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pekko/MANAGEMENT-1.0.0-RC2/ > > > > > > >> > > > > > > >> This release has been signed with a PGP key available here: > > > > > > >> > > > > > > >> https://dist.apache.org/repos/dist/dev/incubator/pekko/KEYS > > > > > > >> > > > > > > >> Release Notes: > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://pekko.apache.org/docs/pekko-management/current/release-notes/index.html > > > > > > >> > > > > > > >> Git branch for the release: > > > > > > >> > > > > > > >> > > > https://github.com/apache/incubator-pekko-management/tree/v1.0.0-RC2 > > > > > > >> Git commit ID: c1bab5a116b7f4c654f9d7ae3886a344e0f3771e > > > > > > >> > > > > > > >> Please download, verify, and test. > > > > > > >> > > > > > > >> We have also staged jars in the Apache Nexus Repository. These > > > were > > > > > > >> built with the same code > > > > > > >> as appears in this Source Release Candidate. We would > appreciate > > > if > > > > > > >> users could test with these too. > > > > > > >> If anyone finds any serious problems with these jars, please > also > > > > > > >> notify us on this thread. > > > > > > >> > > > > > > >> > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > >> > > > > > > >> In sbt, you can add this resolver. > > > > > > >> > > > > > > >> resolvers += "Apache Pekko Staging" at > > > > > > >> "https://repository.apache.org/content/groups/staging" > > > > > > >> > > > > > > >> > > > > > > >> The VOTE will pass if we have more positive votes than > negative > > > votes > > > > > > >> and there must be a minimum of 3 approvals from Pekko PPMC > > > members. > > > > > > >> Anyone voting in favour of the release, could you please > provide a > > > > > > >> list of the checks you have done? > > > > > > >> The vote will be left open until 21:00 UTC on 8 August 2023. > > > > > > >> > > > > > > >> [ ] +1 approve > > > > > > >> [ ] +0 no opinion > > > > > > >> [ ] -1 disapprove with the reason > > > > > > >> > > > > > > >> To learn more about Apache Pekko, please see > > > > > https://pekko.apache.org/ > > > > > > >> > > > > > > >> Checklist for reference: > > > > > > >> > > > > > > >> [ ] Download links are valid. > > > > > > >> [ ] Checksums and signatures. > > > > > > >> [ ] LICENSE/NOTICE files exist > > > > > > >> [ ] No unexpected binary files > > > > > > >> [ ] Source files have ASF headers > > > > > > >> [ ] Can compile from source > > > > > > >> > > > > > > >> To compile from the source, please refer to: > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://github.com/apache/incubator-pekko-management/blob/main/README.md#building-from-source > > > > > > >> > > > > > > >> Some notes about verifying downloads can be found at: > > > > > > >> > > > > > > >> https://pekko.apache.org/download.html#verifying-downloads > > > > > > >> > > > > > > >> > > > > > > >> Here is my +1. > > > > > > >> > > > > > > >> Thanks, > > > > > > >> > > > > > > >> PJ Fanning (Apache Pekko PPMC member) > > > > > > >> > > > > > > >> > > > --------------------------------------------------------------------- > > > > > > >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > >> For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Matthew de Detrich > > > > > > > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > > > > > *m:* +491603708037 > > > > > > > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > Matthew de Detrich > > > > > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > > > *m:* +491603708037 > > > > > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > > -- > > > > > > > > Matthew de Detrich > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > *m:* +491603708037 > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io