Stas Bekman wrote:
Geoffrey Young wrote:
hi
I've implemented apr_table_compress, which was recently added to the APR table API.
the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (and perhaps other recent additions), breaking back compat, or do we need some kind of wrapper to protect users with older httpd/apr versions?
since we don't have a wrapper, this is not a problem for the code generation, as it'll be just ignored.
ignored how? 2.0.38 compiles cleanly but then throws a runtime error when I try and use the function (which I guess that is how it always works when you call an undefined C function)
Hmm, right, I think WrapXS picks things from the Function.pm and not actually checking the C-source.
In that case we need to write a wrapper, which will run, but report a 'not implemented' error.
modperl_apache_compat.c does exactly that. make sure to mark when it was added so when we bump up the minimal required version we can remove the old workarounds.
yeah, that was my thought after I posted. I'll try and figure out in which revision it was added and make the appropriate change via skip().
right
+When C<$flags> == C<APR_OVERLAP_TABLES_SET>, each key will be +set to the last value seen for that key.
should this be:
APR::OVERLAP_TABLES_SET?
While you are at it you may also want to add a comment to docs/api/APR/Const.pod:=head3 C<APR::OVERLAP_TABLES_SET> docs/api/APR/Const.pod:=head3 C<APR::OVERLAP_TABLES_MERGE> and link from Table.pod to these constants, to complete the picture.
and below?
well, the APR_OVERLAP_* stuff was already there - it didn't make sense to me but I figured you had a reason for it :) at any rate, I'll fix the whole doc for that while I'm at it.
I didn't write that doc ;)
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
